[webkit-reviews] review granted: [Bug 223518] [macOS] Context menu should account for image overlay content : [Attachment 423767] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 223518: [macOS] Context menu should account for image overlay content
https://bugs.webkit.org/show_bug.cgi?id=223518

Attachment 423767: Patch

https://bugs.webkit.org/attachment.cgi?id=423767&action=review




--- Comment #2 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 423767
  --> https://bugs.webkit.org/attachment.cgi?id=423767
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423767&action=review

r=me

> Source/WebCore/html/HTMLElement.cpp:1240
> +    if (auto host = node.shadowHost(); is<HTMLElement>(host) &&
downcast<HTMLElement>(*host).hasImageOverlay())
> +	   return makeRefPtr(downcast<HTMLElement>(*host));

NIT: Can we avoid the double dereference-`downcast`?