[webkit-reviews] review canceled: [Bug 223511] GraphicsContextGLOpenGL should avoid calling into ANGLE MakeCurrent : [Attachment 423726] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has canceled  review:
Bug 223511: GraphicsContextGLOpenGL should avoid calling into ANGLE MakeCurrent
https://bugs.webkit.org/show_bug.cgi?id=223511

Attachment 423726: Patch

https://bugs.webkit.org/attachment.cgi?id=423726&action=review




--- Comment #7 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 423726
  --> https://bugs.webkit.org/attachment.cgi?id=423726
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423726&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLOpenGLCocoa.mm:428
> +    if (!m_needsMakeCurrent)

Actually, hang on. If you're rendering WebGL into two different canvases
simultaneously and alternating the calls between the contexts then you have to
check if this == currentContext as the first condition, right?