[webkit-reviews] review granted: [Bug 223528] Update filter-build-webkit : [Attachment 423750] Patch v1.0

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted BJ Burg
<bburg at apple.com>'s request for review:
Bug 223528: Update filter-build-webkit
https://bugs.webkit.org/show_bug.cgi?id=223528

Attachment 423750: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=423750&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 423750
  --> https://bugs.webkit.org/attachment.cgi?id=423750
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423750&action=review

> Tools/Scripts/filter-build-webkit:352
> +    return 1 if $line =~ /^ld: warning: linking with (.+) but not using any
symbols from it/;
> +    return 1 if $line =~ /^ld: warning: dylib \(.*\) was built for newer .*
version (.*) than being linked (.*)$/;

Do we really want to filter these?