[webkit-reviews] review granted: [Bug 223443] Implement RTCDataChannel transfer out of process : [Attachment 423621] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 223443: Implement RTCDataChannel transfer out of process
https://bugs.webkit.org/show_bug.cgi?id=223443

Attachment 423621: Patch

https://bugs.webkit.org/attachment.cgi?id=423621&action=review




--- Comment #4 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423621
  --> https://bugs.webkit.org/attachment.cgi?id=423621
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423621&action=review

> Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.cpp:73
> +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> +    if (Process::identifier() != localIdentifier.processIdentifier)
> +	   return false;
> +
> +    ASSERT(Process::identifier() == localIdentifier.processIdentifier);
> +    if (Process::identifier() != localIdentifier.processIdentifier)
> +	   return false;

This is included twice

>
Source/WebKit/WebProcess/Network/webrtc/RTCDataChannelRemoteManager.messages.in
:34
> +Â  Â  ChangeReadyState(struct WebCore::RTCDataChannelIdentifier handler,
enum:uint8_t WebCore::RTCDataChannelState state);
> +Â  Â  ReceiveData(struct WebCore::RTCDataChannelIdentifier handler, bool
isRaw, IPC::DataReference data);
> +Â  Â  DetectError(struct WebCore::RTCDataChannelIdentifier handler);
> +Â  Â  BufferedAmountIsDecreasing(struct WebCore::RTCDataChannelIdentifier
handler, size_t amount);

Are these tabs?