[webkit-reviews] review requested: [Bug 219283] Make FontCache and FontCascadeCache thread-safe : [Attachment 423716] Patch

[bugzilla-daemon at webkit.org]

Chris Lord <clord at igalia.com> has asked  for review:
Bug 219283: Make FontCache and FontCascadeCache thread-safe
https://bugs.webkit.org/show_bug.cgi?id=219283

Attachment 423716: Patch

https://bugs.webkit.org/attachment.cgi?id=423716&action=review




--- Comment #37 from Chris Lord <clord at igalia.com> ---
Comment on attachment 423716
  --> https://bugs.webkit.org/attachment.cgi?id=423716
Patch

Ok, disregard my previous comment - the null check is required and I've made it
more explicit and corrected the null string misapprehension in
familyNamesAreEqual. I think we're ready for another round again :)

With regards to the locking in FontCascadeFonts, I have added a comment, but
I'm not married to this particular way of doing it if we can think of something
better. It does seem this part of the code has an impact on performance;
locking unconditionally here has a noticeable effect, so it would be good to
come up with a solution that could avoid locking in the common case.