[webkit-reviews] review granted: [Bug 223459] Don't spend time painting transparent cell backgrounds : [Attachment 423622] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 223459: Don't spend time painting transparent cell backgrounds
https://bugs.webkit.org/show_bug.cgi?id=223459

Attachment 423622: Patch

https://bugs.webkit.org/attachment.cgi?id=423622&action=review




--- Comment #2 from Darin Adler <darin at apple.com> ---
Comment on attachment 423622
  --> https://bugs.webkit.org/attachment.cgi?id=423622
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423622&action=review

> Source/WebCore/rendering/RenderTableCell.cpp:1287
> +    if (!bgLayer.hasImage() && (!color.isValid() || !color.isVisible()))

Typically we don’t also have to check isValid if we are checking isVisible,
since the invalid color is also transparent block, and so guaranteed to be
invisible.