[webkit-reviews] review granted: [Bug 223452] Avoid heap allocation under AudioWorkletNode::process() : [Attachment 423650] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 18 14:33:07 PDT 2021

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223452: Avoid heap allocation under AudioWorkletNode::process()

Attachment 423650: Patch


--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 423650
  --> https://bugs.webkit.org/attachment.cgi?id=423650

View in context: https://bugs.webkit.org/attachment.cgi?id=423650&action=review

> Source/WebCore/ChangeLog:26
> +	   behavior is thus consistant with Blink.


> Source/WebCore/Modules/webaudio/AudioWorkletNode.cpp:215
> +	       std::fill(paramValues->data(), paramValues->data() +
framesToProcess, audioParam->finalValue());

How about using std::fill_n instead?

More information about the webkit-reviews mailing list