[webkit-reviews] review granted: [Bug 223413] Add PropertyName parameter to custom setters to allow shared implementations to do late name lookup : [Attachment 423556] Patch

[bugzilla-daemon at webkit.org]

Alexey Shvayka <shvaikalesh at gmail.com> has granted  review:
Bug 223413: Add PropertyName parameter to custom setters to allow shared
implementations to do late name lookup
https://bugs.webkit.org/show_bug.cgi?id=223413

Attachment 423556: Patch

https://bugs.webkit.org/attachment.cgi?id=423556&action=review




--- Comment #2 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 423556
  --> https://bugs.webkit.org/attachment.cgi?id=423556
Patch

Marvelous!
Saam confirmed we are OK with this.

Could you please remove this comment
(https://github.com/WebKit/WebKit/blob/9c1958b2b1f097707106ad5b4096a68a0d8e88f5
/Source/JavaScriptCore/runtime/Lookup.h#L46-L47) on signature? The second
argument isn't necessarily an object, and PropertyName is now needed.

With proper DOMJIT support, we could optimize setters similarly to
https://bugs.webkit.org/show_bug.cgi?id=171637 in future.