[webkit-reviews] review granted: [Bug 223444] Avoid heap allocations under BiquadDSPKernel::updateCoefficientsIfNecessary() : [Attachment 423603] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223444: Avoid heap allocations under
BiquadDSPKernel::updateCoefficientsIfNecessary()
https://bugs.webkit.org/show_bug.cgi?id=223444

Attachment 423603: Patch

https://bugs.webkit.org/attachment.cgi?id=423603&action=review




--- Comment #4 from Darin Adler <darin at apple.com> ---
Comment on attachment 423603
  --> https://bugs.webkit.org/attachment.cgi?id=423603
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423603&action=review

>> Source/WebCore/Modules/webaudio/BiquadDSPKernel.cpp:61
>> +		RELEASE_ASSERT(framesToProcess <=
AudioUtilities::renderQuantumSize);
> 
> Is this change intentional?

I had assumed it was, and I think it’s a good idea to check this at runtime
unconditionally.