[webkit-reviews] review denied: [Bug 222720] REGRESSION(r272900): Nullptr crash in ComposedTreeIterator::traverseNextInShadowTree() via ShadowRoot::hostChildElementDidChange : [Attachment 423480] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 18:05:09 PDT 2021


Ryosuke Niwa <rniwa at webkit.org> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 222720: REGRESSION(r272900): Nullptr crash in
ComposedTreeIterator::traverseNextInShadowTree() via
ShadowRoot::hostChildElementDidChange
https://bugs.webkit.org/show_bug.cgi?id=222720

Attachment 423480: Patch

https://bugs.webkit.org/attachment.cgi?id=423480&action=review




--- Comment #34 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 423480
  --> https://bugs.webkit.org/attachment.cgi?id=423480
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423480&action=review

> Source/WebCore/dom/ComposedTreeIterator.cpp:167
> +	       // FIXME: assignedNode->parentElement() can be nullptr.

r- because this is clearly wrong as Antti says.


More information about the webkit-reviews mailing list