[webkit-reviews] review requested: [Bug 223079] [ macOS Wk2 ] http/tests/security/contentSecurityPolicy/report-only-connect-src-xmlhttprequest-redirect-to-blocked.php is constantly text failing : [Attachment 423530] Patch

[bugzilla-daemon at webkit.org]

Chris Gambrell <cgambrell at apple.com> has asked	for review:
Bug 223079: [ macOS Wk2 ]
http/tests/security/contentSecurityPolicy/report-only-connect-src-xmlhttpreques
t-redirect-to-blocked.php is constantly text failing
https://bugs.webkit.org/show_bug.cgi?id=223079

Attachment 423530: Patch

https://bugs.webkit.org/attachment.cgi?id=423530&action=review




--- Comment #10 from Chris Gambrell <cgambrell at apple.com> ---
Comment on attachment 423530
  --> https://bugs.webkit.org/attachment.cgi?id=423530
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423530&action=review

>
LayoutTests/http/tests/security/contentSecurityPolicy/connect-src-xmlhttpreques
t-redirect-to-blocked-expected.txt:1
> +CONSOLE MESSAGE: Refused to connect to
http://localhost:8000/security/contentSecurityPolicy/resources/xhr-redirect-not
-allowed.py because it does not appear in the connect-src directive of the
Content Security Policy.

Starting process of conversion of pearl files in this patch.

>
LayoutTests/http/tests/security/contentSecurityPolicy/report-document-uri-after
-blocked-redirect-expected.txt:1
> +CONSOLE MESSAGE: Refused to connect to
http://localhost:8000/security/contentSecurityPolicy/resources/xhr-redirect-not
-allowed.py because it does not appear in the connect-src directive of the
Content Security Policy.

Starting process of conversion of pearl files in this patch.

>
LayoutTests/http/tests/security/contentSecurityPolicy/report-document-uri-after
-blocked-redirect.html:24
> +	       xhr.open("GET",
"resources/redir.php?url=http://localhost:8000/security/contentSecurityPolicy/r
esources/xhr-redirect-not-allowed.py", true);

Starting process of conversion of pearl files in this patch.

>
LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-cra
sher-expected.txt:2
> +Blocked access to external URL https://webkit.org/report

Python automatically switched to https above http so changed the url &
expectations

>
LayoutTests/http/tests/security/contentSecurityPolicy/user-style-sheet-font-cra
sher.py:6
> +    'Content-Security-Policy: font-src https://webkit.org; report-uri
https://webkit.org/report;\r\n'

Python automatically switched to https above http so changed the url &
expectations

>
LayoutTests/http/tests/security/contentSecurityPolicy/resources/go-to-echo-repo
rt.py:10
> +    'Content-Type: text/html\r\n\r\n'

When running cURL requests, PHP was returning text/html Content-Type, not
application/javascript

>
LayoutTests/http/tests/security/contentSecurityPolicy/resources/worker-importSc
ript-redirect-cross-origin-allowed.py:8
> +    'Content-Type: text/html\r\n\r\n'

When running cURL requests, PHP was returning text/html Content-Type, not
application/javascript

>
LayoutTests/http/tests/security/contentSecurityPolicy/resources/worker-importSc
ript-redirect-cross-origin-blocked.py:8
> +    'Content-Type: text/html\r\n\r\n'

When running cURL requests, PHP was returning text/html Content-Type, not
application/javascript

>
LayoutTests/http/tests/security/contentSecurityPolicy/resources/worker-xhr-allo
wed.py:8
> +    'Content-Type: text/html\r\n\r\n'

When running cURL requests, PHP was returning text/html Content-Type, not
application/javascript

>
LayoutTests/http/tests/security/contentSecurityPolicy/resources/worker-xhr-redi
rect-cross-origin-allowed.py:7
> +    'Content-Type: text/html\r\n\r\n'

When running cURL requests, PHP was returning text/html Content-Type, not
application/javascript

>
LayoutTests/http/tests/security/contentSecurityPolicy/resources/worker-xhr-redi
rect-cross-origin-blocked.py:8
> +    'Content-Type: text/html\r\n\r\n'

When running cURL requests, PHP was returning text/html Content-Type, not
application/javascript

>
LayoutTests/http/tests/security/contentSecurityPolicy/resources/xhr-redirect-no
t-allowed.py:1
> +#!/usr/bin/env python3

Starting process of conversion of pearl files in this patch.