[webkit-reviews] review canceled: [Bug 223309] modern-media-controls script should not be allocated in heap : [Attachment 423513] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 12:27:54 PDT 2021


Yusuke Suzuki <ysuzuki at apple.com> has canceled Yusuke Suzuki
<ysuzuki at apple.com>'s request for review:
Bug 223309: modern-media-controls script should not be allocated in heap
https://bugs.webkit.org/show_bug.cgi?id=223309

Attachment 423513: Patch

https://bugs.webkit.org/attachment.cgi?id=423513&action=review




--- Comment #14 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 423513
  --> https://bugs.webkit.org/attachment.cgi?id=423513
Patch

Ah, let me wait. It seems that we are allocating memory for String(CFString).
We should serialize script into C characters as we do in builtin code and place
it into __DATA_CONST.


More information about the webkit-reviews mailing list