[webkit-reviews] review granted: [Bug 223388] Determine if we have useFastJITPermissions on arm64e at runtime instead of hardcoding it as always enabled : [Attachment 423510] patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 223388: Determine if we have useFastJITPermissions on arm64e at runtime
instead of hardcoding it as always enabled
https://bugs.webkit.org/show_bug.cgi?id=223388

Attachment 423510: patch

https://bugs.webkit.org/attachment.cgi?id=423510&action=review




--- Comment #4 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 423510
  --> https://bugs.webkit.org/attachment.cgi?id=423510
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423510&action=review

r=me with suggested improvement.

> Source/WTF/wtf/PlatformEnableCocoa.h:477
> +#if !defined(ENABLE_SEPARATED_WX_HEAP) && CPU(ARM64)
>  #define ENABLE_SEPARATED_WX_HEAP 1

We used to not build in the code for initializeSeparatedWXHeaps() and
jitWriteThunkGenerator() at all on ARM64E.  Now, we do.  Can you add the
following to those 2 functions as a sanity check:

    auto exitScope = makeScopeExit([] {
	RELEASE_ASSERT(!g_jscConfig.useFastJITPermissions);
    });