[webkit-reviews] review granted: [Bug 223389] Add logging to FullscreenManager. : [Attachment 423506] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 223389: Add logging to FullscreenManager.
https://bugs.webkit.org/show_bug.cgi?id=223389

Attachment 423506: Patch

https://bugs.webkit.org/attachment.cgi?id=423506&action=review




--- Comment #2 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423506
  --> https://bugs.webkit.org/attachment.cgi?id=423506
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423506&action=review

> Source/WebCore/dom/FullscreenManager.cpp:50
> +static const char* logClassName() { return "FullscreenManager"; }
> +static WTFLogChannel& logChannel() { return LogFullscreen; }

As we discussed, this is foot gun with the unified build system.