[webkit-reviews] review granted: [Bug 222590] Maybe-regression(STP121): window.open flakily returning null : [Attachment 423488] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 17 09:43:40 PDT 2021

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 222590: Maybe-regression(STP121): window.open flakily returning null

Attachment 423488: Patch


--- Comment #24 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 423488
  --> https://bugs.webkit.org/attachment.cgi?id=423488


I... can't believe this worked? :P But I love it!

Another way to think of MaintainOrderingWithAsyncMessages is that it's a way to
say "this sync IPC is actually sent as more than one message, with the final
message being marked sync -- but it would be crazy to take all those messages
and package them up into one giant sync message, so we use this flag instead".

I bet we can remove DispatchMessageEvenWhenWaitingForSyncReply now, and replace
it with MaintainOrderingWithAsyncMessages. The benefit would be that we
annotate the message that needs the behavior, rather than the unrelated
messages that just get caught in the fray -- so our code becomes more precise,
which hopefully makes it more robust.

More information about the webkit-reviews mailing list