[webkit-reviews] review granted: [Bug 223248] Apply permission policy to geolocation : [Attachment 423328] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 223248: Apply permission policy to geolocation
https://bugs.webkit.org/show_bug.cgi?id=223248

Attachment 423328: Patch

https://bugs.webkit.org/attachment.cgi?id=423328&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423328
  --> https://bugs.webkit.org/attachment.cgi?id=423328
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423328&action=review

> Source/WebCore/Modules/geolocation/Geolocation.cpp:358
> +    if
(!isFeaturePolicyAllowedByDocumentAndAllOwners(FeaturePolicy::Type::Geolocation
, *document(), LogFeaturePolicyFailure::Yes))
> +	   return true;

As we discussed, I think a linked-on-or-after check would be a good idea so we
don't break existing apps that depend on the old behavior.