[webkit-reviews] review granted: [Bug 223277] Many media/media-fragments/ tests are crashing due to other tests that run before them. : [Attachment 423407] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 223277: Many media/media-fragments/ tests are crashing due to other tests
that run before them.
https://bugs.webkit.org/show_bug.cgi?id=223277

Attachment 423407: Patch

https://bugs.webkit.org/attachment.cgi?id=423407&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423407
  --> https://bugs.webkit.org/attachment.cgi?id=423407
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423407&action=review

>
Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundati
onObjC.mm:846
> +	   size_t count = 0;
> +	   auto results = fragmentParameter.splitAllowingEmptyEntries('=');
> +	   for (auto iterator = results.begin(); iterator != results.end();
++iterator)
> +	       ++count;
> +	   return count != 2;

Couldn't this be just:

    return fragmentParameter.splitAllowingEmptyEntries('=').size != 2;