[webkit-reviews] review granted: [Bug 222239] Regressions from ANGLE Metal enablement : [Attachment 423368] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 14:52:49 PDT 2021


Dean Jackson <dino at apple.com> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 222239: Regressions from ANGLE Metal enablement
https://bugs.webkit.org/show_bug.cgi?id=222239

Attachment 423368: Patch

https://bugs.webkit.org/attachment.cgi?id=423368&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 423368
  --> https://bugs.webkit.org/attachment.cgi?id=423368
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423368&action=review

> Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect.h:103
> +	   ASSERT(0);

We probably should put a message in here.

> Source/ThirdParty/ANGLE/src/compiler/translator/TranslatorMetalDirect.h:113
>	   ASSERT(0);

And here.


More information about the webkit-reviews mailing list