[webkit-reviews] review granted: [Bug 179904] [Cocoa] Web Inspector: load inspector resources using a custom scheme handler : [Attachment 423388] Patch v1.0

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted BJ Burg <bburg at apple.com>'s
request for review:
Bug 179904: [Cocoa] Web Inspector: load inspector resources using a custom
scheme handler
https://bugs.webkit.org/show_bug.cgi?id=179904

Attachment 423388: Patch v1.0

https://bugs.webkit.org/attachment.cgi?id=423388&action=review




--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 423388
  --> https://bugs.webkit.org/attachment.cgi?id=423388
Patch v1.0

View in context: https://bugs.webkit.org/attachment.cgi?id=423388&action=review

r=me

>
Source/WebKit/UIProcess/Inspector/mac/WKInspectorResourceURLSchemeHandler.mm:89
> +    [[NSOperationQueue mainQueue] addOperation:_fileLoadOperation];

Let's do this file access off the main thread to keep the app responsive.