[webkit-reviews] review granted: [Bug 223222] [Cocoa] Update legacy WebKit thread checks to prepare for use on iOS and modern WebKit : [Attachment 423263] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 12:41:57 PDT 2021


Chris Dumez <cdumez at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 223222: [Cocoa] Update legacy WebKit thread checks to prepare for use on
iOS and modern WebKit
https://bugs.webkit.org/show_bug.cgi?id=223222

Attachment 423263: Patch

https://bugs.webkit.org/attachment.cgi?id=423263&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 423263
  --> https://bugs.webkit.org/attachment.cgi?id=423263
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423263&action=review

Looks good to me.

> Source/WebCore/platform/mac/ThreadCheck.mm:74
> +	   NSLog(@"WebKit Threading Violation - %s was called from secondary
thread", function);

Maybe we should be using RELEASE_LOG_ERROR() so that its stands out in console
logging as an error?

> Source/WebCore/platform/mac/ThreadCheck.mm:75
> +	   NSLog(@"Additional threading violations for this function will not
be logged.");

ditto.

> Source/WebCore/platform/mac/ThreadCheck.mm:78
> +	   NSLog(@"WebKit Threading Violation - %s was called from secondary
thread", function);

Ditto.


More information about the webkit-reviews mailing list