[webkit-reviews] review granted: [Bug 223238] PCM: Test infrastructure for sending attribution reports to attribution website too : [Attachment 423339] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 16 11:43:23 PDT 2021


Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 223238: PCM: Test infrastructure for sending attribution reports to
attribution website too
https://bugs.webkit.org/show_bug.cgi?id=223238

Attachment 423339: Patch

https://bugs.webkit.org/attachment.cgi?id=423339&action=review




--- Comment #5 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 423339
  --> https://bugs.webkit.org/attachment.cgi?id=423339
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423339&action=review

r=me

>
LayoutTests/http/tests/contentextensions/block-private-click-measurement.html:1
8
> +	  
testRunner.setPrivateClickMeasurementAttributionReportURLsForTesting("http://12
7.0.0.1:8000/privateClickMeasurement/resources/conversionReport.php",
"http://localhost:8000/privateClickMeasurement/resources/conversionReport.php")
;

It's too bad we don't have two separate endpoints
(conversionReportForAttribution.php or something)


More information about the webkit-reviews mailing list