[webkit-reviews] review granted: [Bug 223141] Runtime-disabled CSS features still still appear enabled via two-arg CSS.supports() : [Attachment 423362] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 223141: Runtime-disabled CSS features still still appear enabled via
two-arg CSS.supports()
https://bugs.webkit.org/show_bug.cgi?id=223141

Attachment 423362: Patch

https://bugs.webkit.org/attachment.cgi?id=423362&action=review




--- Comment #4 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 423362
  --> https://bugs.webkit.org/attachment.cgi?id=423362
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423362&action=review

> Source/WebCore/css/DOMCSSNamespace.cpp:67
>  
> +    CSSParserContext parserContext(document);
> +    if (parserContext.isPropertyRuntimeDisabled(propertyID))
> +	   propertyID = CSSPropertyInvalid;
> +
>      if (propertyID == CSSPropertyInvalid)
>	   return false;

You can just return false in the first branch