[webkit-reviews] review granted: [Bug 223205] Add CSSValuePair.h in preparation for Pair.h refactor : [Attachment 423260] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tyler Wilcock
<twilco.o at protonmail.com>'s request for review:
Bug 223205: Add CSSValuePair.h in preparation for Pair.h refactor
https://bugs.webkit.org/show_bug.cgi?id=223205

Attachment 423260: Patch

https://bugs.webkit.org/attachment.cgi?id=423260&action=review




--- Comment #3 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 423260
  --> https://bugs.webkit.org/attachment.cgi?id=423260
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423260&action=review

> Source/WebCore/css/CSSValuePair.cpp:37
> +    return first + separatorCssText() + second;

makeString() might be more efficient.

> Source/WebCore/css/CSSValuePair.h:36
> + * Intended to replace Pair.h, which is only capable of containing
CSSPrimitiveValues, and is not a sub-class of
> + * CSSValue itself. See https://bugs.webkit.org/show_bug.cgi?id=223204.

This comment won't be useful in the future when Pair.h is lost in the mists of
time.