[webkit-reviews] review requested: [Bug 219283] Make FontCache and FontCascadeCache thread-safe : [Attachment 423321] Patch

[bugzilla-daemon at webkit.org]

Chris Lord <clord at igalia.com> has asked  for review:
Bug 219283: Make FontCache and FontCascadeCache thread-safe
https://bugs.webkit.org/show_bug.cgi?id=219283

Attachment 423321: Patch

https://bugs.webkit.org/attachment.cgi?id=423321&action=review




--- Comment #14 from Chris Lord <clord at igalia.com> ---
Comment on attachment 423321
  --> https://bugs.webkit.org/attachment.cgi?id=423321
Patch

I think this is at least ready for another review round and further discussion.

I followed Darin's advice re changing the API for
FontCache::platformAlternateFamilyName and that did indeed simplify things
along that path. I also took a look through FontCache a bit more carefully and
made sure to use isolated copies of strings that it expects to keep and use
from multiple threads.

I think we could all feel more comfortable with this patch if there were more
opportunities to assert if something behaves incorrectly, but no ideas are
immediately coming to mind.

Feedback very much appreciated.