[webkit-reviews] review granted: [Bug 223191] Attempt to restore highlights after paint to account for newly loaded content. : [Attachment 423302] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 23:05:53 PDT 2021


Tim Horton <thorton at apple.com> has granted Megan Gardner
<megan_gardner at apple.com>'s request for review:
Bug 223191: Attempt to restore highlights after paint to account for newly
loaded content.
https://bugs.webkit.org/show_bug.cgi?id=223191

Attachment 423302: Patch

https://bugs.webkit.org/attachment.cgi?id=423302&action=review




--- Comment #15 from Tim Horton <thorton at apple.com> ---
Comment on attachment 423302
  --> https://bugs.webkit.org/attachment.cgi?id=423302
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423302&action=review

> Source/WebCore/page/Page.cpp:1614
> +	   if (auto appHighlightStorage =
document.appHighlightStorageIfExists()) {

This could just be an early return, since you're in a lambda


More information about the webkit-reviews mailing list