[webkit-reviews] review granted: [Bug 221246] Web Inspector: remove experimental setting and enable Layout sidebar : [Attachment 423264] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 22:44:20 PDT 2021


BJ Burg <bburg at apple.com> has granted Nikita Vasilyev <nvasilyev at apple.com>'s
request for review:
Bug 221246: Web Inspector: remove experimental setting and enable Layout
sidebar
https://bugs.webkit.org/show_bug.cgi?id=221246

Attachment 423264: Patch

https://bugs.webkit.org/attachment.cgi?id=423264&action=review




--- Comment #9 from BJ Burg <bburg at apple.com> ---
Comment on attachment 423264
  --> https://bugs.webkit.org/attachment.cgi?id=423264
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423264&action=review

r=me

>> Source/WebInspectorUI/UserInterface/Views/ElementsTabContentView.js:36
>> +	    if (InspectorBackend.hasCommand("DOM.showGridOverlay"))
> 
> I don't know if should check for anything else here. Other commands were
added around the same time, and it looks like we usually check for only one
command elsewhere in our codebase.

This is fine.


More information about the webkit-reviews mailing list