[webkit-reviews] review granted: [Bug 221783] ASSERTION FAILED: m_state == State::Committed in WebKit::FrameLoadState::didFailLoad() : [Attachment 423289] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 15 20:33:03 PDT 2021
Ryosuke Niwa <rniwa at webkit.org> has granted Julian Gonzalez
<julian_a_gonzalez at apple.com>'s request for review:
Bug 221783: ASSERTION FAILED: m_state == State::Committed in
WebKit::FrameLoadState::didFailLoad()
https://bugs.webkit.org/show_bug.cgi?id=221783
Attachment 423289: Patch
https://bugs.webkit.org/attachment.cgi?id=423289&action=review
--- Comment #14 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 423289
--> https://bugs.webkit.org/attachment.cgi?id=423289
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=423289&action=review
> Source/WebCore/editing/FrameSelection.h:302
> + enum ShouldUpdateAppearance : bool { No, Yes };
Please use enum class, not enum.
Otherwise, there will be implicit type coercion between this type and bool,
and No/Yes will pollute the namespace within FrameSelection.
More information about the webkit-reviews
mailing list