[webkit-reviews] review granted: [Bug 223168] Add internal additions for WebAuthn compatibility : [Attachment 423255] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted katherine_cheney at apple.com's
request for review:
Bug 223168: Add internal additions for WebAuthn compatibility
https://bugs.webkit.org/show_bug.cgi?id=223168

Attachment 423255: Patch

https://bugs.webkit.org/attachment.cgi?id=423255&action=review




--- Comment #9 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 423255
  --> https://bugs.webkit.org/attachment.cgi?id=423255
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423255&action=review

r=me

> Source/WebKit/UIProcess/WebAuthentication/Cocoa/LocalAuthenticator.mm:54
> +static NSDictionary *createAlternateQuery(const String&) { return
[NSDictionary alloc]; }

Could this just be return nil, or perhapss ASSERT_NOT_REACHED? I don't think we
should ever hit this code path.