[webkit-reviews] review granted: [Bug 223220] [Multi-column] Ignore line grid offset when the grid line is shorter than 0.5px : [Attachment 423258] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted zalan
<zalan at apple.com>'s request for review:
Bug 223220: [Multi-column] Ignore line grid offset when the grid line is
shorter than 0.5px
https://bugs.webkit.org/show_bug.cgi?id=223220

Attachment 423258: Patch

https://bugs.webkit.org/attachment.cgi?id=423258&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 423258
  --> https://bugs.webkit.org/attachment.cgi?id=423258
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423258&action=review

> Source/WebCore/rendering/RenderLayoutState.cpp:205
> +    if (!roundToInt(lineGridBox->lineBoxHeight()))

Maybe store lineBoxHeight in a local variable since this code now calls it
three times.