[webkit-reviews] review granted: [Bug 223203] Change canvasChanged() to take a Optional<FloatRect> : [Attachment 423216] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Mar 15 12:31:59 PDT 2021
Said Abou-Hallawa <sabouhallawa at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 223203: Change canvasChanged() to take a Optional<FloatRect>
https://bugs.webkit.org/show_bug.cgi?id=223203
Attachment 423216: Patch
https://bugs.webkit.org/attachment.cgi?id=423216&action=review
--- Comment #3 from Said Abou-Hallawa <sabouhallawa at apple.com> ---
Comment on attachment 423216
--> https://bugs.webkit.org/attachment.cgi?id=423216
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=423216&action=review
> Source/WebCore/html/canvas/CanvasRenderingContext2DBase.h:322
> + FloatRect backingStoreBounds() const { return FloatRect { { }, FloatSize
{ canvasBase().size() } }; }
I think you can omit FloatRect and FloatSize.
More information about the webkit-reviews
mailing list