[webkit-reviews] review granted: [Bug 222990] Web Inspector: `Styles` sidebar pseudo-class checkboxes appear cramped after resizing window at narrow widths : [Attachment 423058] Patch v1.1 - Revised setting selected panel for exclusive SingleSidebars

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has granted Patrick Angle <pangle at apple.com>'s
request for review:
Bug 222990: Web Inspector: `Styles` sidebar pseudo-class checkboxes appear
cramped after resizing window at narrow widths
https://bugs.webkit.org/show_bug.cgi?id=222990

Attachment 423058: Patch v1.1 - Revised setting selected panel for exclusive
SingleSidebars

https://bugs.webkit.org/attachment.cgi?id=423058&action=review




--- Comment #8 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 423058
  --> https://bugs.webkit.org/attachment.cgi?id=423058
Patch v1.1 - Revised setting selected panel for exclusive SingleSidebars

View in context: https://bugs.webkit.org/attachment.cgi?id=423058&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/MultiSidebar.js:189
> +    _updateMinimumWidthForMultipleSidebars({ignoreExistingComputedValue} =
{})

NIT: While I do appreciate you using an object for options like this,
personally for things that are inside the same class (and only have one
argument) I'd just make this a `force` parameter that's not in an object. 
Nothing wrong with how you have it here tho so your call :)

> Source/WebInspectorUI/UserInterface/Views/MultiSidebar.js:256
>	   sidebar.selectedSidebarPanel = sidebarPanel;

Remove this?