[webkit-reviews] review granted: [Bug 222376] [css-grid] Replace the use of -1 with WTF::nullopt : [Attachment 423033] Patch

[bugzilla-daemon at webkit.org]

Javier Fernandez <jfernandez at igalia.com> has granted zsun at igalia.com's request
for review:
Bug 222376: [css-grid] Replace the use of -1 with WTF::nullopt
https://bugs.webkit.org/show_bug.cgi?id=222376

Attachment 423033: Patch

https://bugs.webkit.org/attachment.cgi?id=423033&action=review




--- Comment #19 from Javier Fernandez <jfernandez at igalia.com> ---
Comment on attachment 423033
  --> https://bugs.webkit.org/attachment.cgi?id=423033
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423033&action=review

r=me

> Source/WebCore/ChangeLog:8
> +	   This change replaces -1 with nullopt in grid to indicate indefinite
for funtions that

s/funtions/functions

> Source/WebCore/ChangeLog:9
> +	   returns an Optional type. This change has exposed an issue when
resolving replaced elemnt

s/elemnt/element

> Source/WebCore/rendering/RenderReplaced.cpp:357
>	   if (hasAutoHeightOrContainingBlockWithAutoHeight())

Nit: Maybe we can change this as well, something like this:

return !hasAutoHeightOrContainingBlockWithAutoHeight()