[webkit-reviews] review denied: [Bug 223181] Fix interpolation of the caret-color CSS property : [Attachment 423172] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 06:44:13 PDT 2021


Antti Koivisto <koivisto at iki.fi> has denied Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 223181: Fix interpolation of the caret-color CSS property
https://bugs.webkit.org/show_bug.cgi?id=223181

Attachment 423172: Patch

https://bugs.webkit.org/attachment.cgi?id=423172&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 423172
  --> https://bugs.webkit.org/attachment.cgi?id=423172
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423172&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2788
> +	       if (!m_allowVisitedStyle && style.hasAutoCaretColor())
> +		   return cssValuePool.createIdentifierValue(CSSValueAuto);
> +	       if (m_allowVisitedStyle && style.hasVisitedLinkAutoCaretColor())
> +		   return cssValuePool.createIdentifierValue(CSSValueAuto);

Please don't expand visited link support!


More information about the webkit-reviews mailing list