[webkit-reviews] review granted: [Bug 223133] [GTK] Kinetic iframe async scrolling does not work : [Attachment 423075] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 15 02:29:30 PDT 2021


Carlos Garcia Campos <cgarcia at igalia.com> has granted Alejandro G. Castro
<alex at igalia.com>'s request for review:
Bug 223133: [GTK] Kinetic iframe async scrolling does not work
https://bugs.webkit.org/show_bug.cgi?id=223133

Attachment 423075: Patch

https://bugs.webkit.org/attachment.cgi?id=423075&action=review




--- Comment #2 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Comment on attachment 423075
  --> https://bugs.webkit.org/attachment.cgi?id=423075
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423075&action=review

> Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:173
> +#if PLATFORM(GTK)
> +    if (wheelEvent.isEndOfNonMomentumScroll())
> +	   return true;
> +#endif

Maybe this check fits better in
ScrollingTreeScrollingNode::canHandleWheelEvent() before calling
eventCanScrollContents(), and including a comment explaining why.


More information about the webkit-reviews mailing list