[webkit-reviews] review granted: [Bug 223158] [JSC] Run one Mozilla test explicitly under PST since this test does not work when we are moving from PST to PDT : [Attachment 423120] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 223158: [JSC] Run one Mozilla test explicitly under PST since this test
does not work when we are moving from PST to PDT
https://bugs.webkit.org/show_bug.cgi?id=223158

Attachment 423120: Patch

https://bugs.webkit.org/attachment.cgi?id=423120&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 423120
  --> https://bugs.webkit.org/attachment.cgi?id=423120
Patch

r=me

Thanks for fixing this.  This bug has been present going back at least 8 years.
 For 2 hours a year when we switch daylight savings time, this test would
always fail.

I see that the real change that matters is that you specified "TZ=PST" and use
runComplexTest to get it applied to the environment.  However, I wasn't able to
tease out where our system picks up this env var.  Would you mind pointing me
to it for future reference?