[webkit-reviews] review granted: [Bug 141952] GenericArguments<Type>::getOwnPropertyNames() should respect modified descriptors : [Attachment 423105] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 13 18:23:07 PST 2021

Yusuke Suzuki <ysuzuki at apple.com> has granted Alexey Shvayka
<shvaikalesh at gmail.com>'s request for review:
Bug 141952: GenericArguments<Type>::getOwnPropertyNames() should respect
modified descriptors

Attachment 423105: Patch


--- Comment #4 from Yusuke Suzuki <ysuzuki at apple.com> ---
Comment on attachment 423105
  --> https://bugs.webkit.org/attachment.cgi?id=423105

View in context: https://bugs.webkit.org/attachment.cgi?id=423105&action=review


> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:101
> +    auto shouldEnumerateIndex = [&] (unsigned index) -> bool {

Let's take JSGlobalObject since it can throw an error now.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:107
> +	   bool hasProperty = Base::getOwnPropertySlotByIndex(thisObject,
globalObject, index, slot);
> +	   slot.disallowVMEntry.reset();

Let's do an error check here still because we still have a chance invoking OOM
errors etc.

> Source/JavaScriptCore/runtime/GenericArgumentsInlines.h:116
> +	       if (shouldEnumerateIndex(i))

Let's insert RETURN_IF_EXCEPTION after this call.

More information about the webkit-reviews mailing list