[webkit-reviews] review granted: [Bug 223118] Show media session image artwork in Now Playing information pane. : [Attachment 423093] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jean-Yves Avenard [:jya]
<jya at apple.com>'s request for review:
Bug 223118: Show media session image artwork in Now Playing information pane.
https://bugs.webkit.org/show_bug.cgi?id=223118

Attachment 423093: Patch

https://bugs.webkit.org/attachment.cgi?id=423093&action=review




--- Comment #6 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 423093
  --> https://bugs.webkit.org/attachment.cgi?id=423093
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423093&action=review

This looks good, but I think it is important to add a test before landing.

> Source/WebCore/ChangeLog:9
> +	   Manually tested, no framework available to test this feature.

We can at least test image loader. 

You could, for example, add a method to Internals that returns a promise which
resolves with the artwork image once it loads. See
Internals::grabNextMediaStreamTrackFrame and the test
LayoutTests/fast/mediastream/captureStream/canvas3d.html for one way this could
be done.