[webkit-reviews] review granted: [Bug 222739] Cache cross-origin methods / accessors of Window and Location per lexical global object : [Attachment 422986] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 13 00:40:19 PST 2021
Alexey Shvayka <shvaikalesh at gmail.com> has granted review:
Bug 222739: Cache cross-origin methods / accessors of Window and Location per
lexical global object
https://bugs.webkit.org/show_bug.cgi?id=222739
Attachment 422986: Patch
https://bugs.webkit.org/attachment.cgi?id=422986&action=review
--- Comment #11 from Alexey Shvayka <shvaikalesh at gmail.com> ---
Comment on attachment 422986
--> https://bugs.webkit.org/attachment.cgi?id=422986
Patch
(In reply to Alexey Shvayka from comment #10)
> Created attachment 422986 [details]
> Patch
>
> Proper Windows build fix.
That did the trick. Judging by other Windows builds, the failures are
pre-existing, but were not confirmed as such because rebuild without patch has
failed.
I am putting r+ on my own patch so the WPT export bot would (hopefully) approve
my PR.
The bot doesn't consider the patch reviewed by Darin as it's now obsolete.
More information about the webkit-reviews
mailing list