[webkit-reviews] review granted: [Bug 223082] Shutdown ANGLE on GPU process when last WebGL context is destroyed : [Attachment 423062] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Kimmo Kinnunen
<kkinnunen at apple.com>'s request for review:
Bug 223082: Shutdown ANGLE on GPU process when last WebGL context is destroyed
https://bugs.webkit.org/show_bug.cgi?id=223082

Attachment 423062: Patch

https://bugs.webkit.org/attachment.cgi?id=423062&action=review




--- Comment #5 from Kenneth Russell <kbr at google.com> ---
Comment on attachment 423062
  --> https://bugs.webkit.org/attachment.cgi?id=423062
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423062&action=review

Looks good. The retain/release code looks correct to me. A few small points; r+
though.

> Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLEEGLUtilities.h:2
> + * Copyright (C) 2020 Apple Inc. All rights reserved.

2021?

> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:55
> +static constexpr Seconds dispatchReleaseAllResourcesIfUnusedTimeout = 0.2_s;

This feels like a short timeout to me. Consider bumping it up, maybe even to 1s
or so.

> Source/WebKit/GPUProcess/graphics/RemoteGraphicsContextGL.cpp:56
> +static unsigned remoteGraphicsContextCount;

Guaranteed to be zero-initialized?