[webkit-reviews] review requested: [Bug 219283] Make FontCache and FontCascadeCache thread-safe : [Attachment 423029] Patch

[bugzilla-daemon at webkit.org]

Chris Lord <clord at igalia.com> has asked  for review:
Bug 219283: Make FontCache and FontCascadeCache thread-safe
https://bugs.webkit.org/show_bug.cgi?id=219283

Attachment 423029: Patch

https://bugs.webkit.org/attachment.cgi?id=423029&action=review




--- Comment #6 from Chris Lord <clord at igalia.com> ---
Comment on attachment 423029
  --> https://bugs.webkit.org/attachment.cgi?id=423029
Patch

Just to note, I realise the ChangeLog message is inadequate, I just don't want
to needlessly retrigger EWS tests. Pretend it says this:

"Remove the iOS-specific lock in FontCache and add a platform-independent lock
that guards functions that use data that isn't safe for concurrent access. Make
similar changes in some related classes so that FontCache becomes usable off
the main thread."

Also, for what it's worth, I've tested using a simple, canvas-based, font
loading/drawing performance test and there's no discernable difference after
applying this patch. I would certainly make sure this gets broader testing than
that before even considering committing it though.