[webkit-reviews] review granted: [Bug 223111] Fix interpolation of perspective property : [Attachment 423018] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Antoine Quint
<graouts at webkit.org>'s request for review:
Bug 223111: Fix interpolation of perspective property
https://bugs.webkit.org/show_bug.cgi?id=223111

Attachment 423018: Patch

https://bugs.webkit.org/attachment.cgi?id=423018&action=review




--- Comment #2 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 423018
  --> https://bugs.webkit.org/attachment.cgi?id=423018
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=423018&action=review

> Source/WebCore/rendering/style/RenderStyle.h:719
> +    bool hasPerspective() const { return m_rareNonInheritedData->perspective
!= -1; }

Maybe this could compare against initialPerspective() instead of -1 to be less
magical.

> Source/WebCore/style/StyleBuilderConverter.h:1229
> -	   return 0.f;
> +	   return -1;

Similarly this could return RenderStyle::initialPerspective().