[webkit-reviews] review granted: [Bug 223087] Introduce WorkQueue::main() to get the main thread's work queue : [Attachment 422972] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 223087: Introduce WorkQueue::main() to get the main thread's work queue
https://bugs.webkit.org/show_bug.cgi?id=223087

Attachment 422972: Patch

https://bugs.webkit.org/attachment.cgi?id=422972&action=review




--- Comment #5 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 422972
  --> https://bugs.webkit.org/attachment.cgi?id=422972
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422972&action=review

r=me

> Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:214
> -    dispatch_async(dispatch_get_main_queue(), makeBlockPtr([this, strongThis
= makeRef(*this), callbackID] {
> +    WorkQueue::main().dispatch([this, strongThis = makeRef(*this),
callbackID] {

I wonder about cases like this. Do they use WorkQueue rather than RunLoop for
any specific purpose? Perhaps we should just make RunLoop::main() safe to call
before main thread initialization, just like WorkQueue::main.