[webkit-reviews] review granted: [Bug 223078] [macCatalyst] media controls should have macOS styling and behavior : [Attachment 422946] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 11 11:18:24 PST 2021


Eric Carlson <eric.carlson at apple.com> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 223078: [macCatalyst] media controls should have macOS styling and behavior
https://bugs.webkit.org/show_bug.cgi?id=223078

Attachment 422946: Patch

https://bugs.webkit.org/attachment.cgi?id=422946&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 422946
  --> https://bugs.webkit.org/attachment.cgi?id=422946
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422946&action=review

> Source/WebCore/Modules/mediacontrols/MediaControlsHost.cpp:117
> +    return nullString();

ASSERT_NOT_REACHED()?


More information about the webkit-reviews mailing list