[webkit-reviews] review granted: [Bug 222995] Add some logging to help debug flaky quota tests : [Attachment 422838] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 11 11:06:52 PST 2021

youenn fablet <youennf at gmail.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 222995: Add some logging to help debug flaky quota tests

Attachment 422838: Patch


--- Comment #4 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 422838
  --> https://bugs.webkit.org/attachment.cgi?id=422838

I guess the idea is to remove that logging after investigation.
That seems ok.
Otherwise, I would go with something like RELEASE_LOG_WITH_LEVEL_IF, pass
session IDs as part of the IF, and use Verbose level.

And maybe add some test runner API to turn the logging info on a per test

More information about the webkit-reviews mailing list