[webkit-reviews] review granted: [Bug 223049] Introduce WorkQueue::dispatchSync() : [Attachment 422888] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 11 07:44:57 PST 2021
Alex Christensen <achristensen at apple.com> has granted Chris Dumez
<cdumez at apple.com>'s request for review:
Bug 223049: Introduce WorkQueue::dispatchSync()
https://bugs.webkit.org/show_bug.cgi?id=223049
Attachment 422888: Patch
https://bugs.webkit.org/attachment.cgi?id=422888&action=review
--- Comment #4 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 422888
--> https://bugs.webkit.org/attachment.cgi?id=422888
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422888&action=review
> Source/WTF/wtf/cocoa/WorkQueueCocoa.cpp:50
> + dispatch_sync(m_dispatchQueue.get(), makeBlockPtr([protectedThis =
makeRef(*this), function = WTFMove(function)] {
Do we need to protect this, since we won't return until the dispatch_sync
returns?
More information about the webkit-reviews
mailing list