[webkit-reviews] review granted: [Bug 222976] Cleanup RenderFlexibleBox : [Attachment 422912] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 11 04:51:21 PST 2021

Sergio Villar Senin <svillar at igalia.com> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 222976: Cleanup RenderFlexibleBox

Attachment 422912: Patch


--- Comment #6 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 422912
  --> https://bugs.webkit.org/attachment.cgi?id=422912

View in context: https://bugs.webkit.org/attachment.cgi?id=422912&action=review

Thanks for the cleanup!

> Source/WebCore/rendering/RenderFlexibleBox.cpp:1226
> +	       return std::max(childSize, std::min(transferredSize,

This is correct from the current API POV, but I think we should review at some
point computeMainSizeFromAspectRatioUsing() because it's OK if it returns a
nullopt. Right now it isn't possible because we replace it by 0_lu just before
returning but I think that is not very precise. Could you add some FIXME so
that we don't forget about it?

More information about the webkit-reviews mailing list