[webkit-reviews] review denied: [Bug 222959] [CMake] Build fails on RISC-V with GCC 11 : [Attachment 422903] potential fix 2

[bugzilla-daemon at webkit.org]

Adrian Perez <aperez at igalia.com> has denied  review:
Bug 222959: [CMake] Build fails on RISC-V with GCC 11
https://bugs.webkit.org/show_bug.cgi?id=222959

Attachment 422903: potential fix 2

https://bugs.webkit.org/attachment.cgi?id=422903&action=review




--- Comment #9 from Adrian Perez <aperez at igalia.com> ---
Comment on attachment 422903
  --> https://bugs.webkit.org/attachment.cgi?id=422903
potential fix 2

Hi again!

The patch is not *almost* ready. There are a couple of small changes
needed—please take a look.

And no worries, it's normal to run into these issues when submitting
patches to WebKit in the beginning, thanks for your patience.  :) 

View in context: https://bugs.webkit.org/attachment.cgi?id=422903&action=review

> ChangeLog:4
> +	architevtures (e.g. RISCV) operations on less than 4 bytes are not
lock-free 

This line is using tabs for indentation. In the ChangeLog files we use
always 8 spaces. This is the reason why the “style” build bot is red.
You can click the status bubbles to read the logs, in this case the
log is at:

  https://ews-build.webkit.org/#/builders/6/builds/42288

You can use ”Tools/Scripts/check-webkit-style” if you want to verify
patches before submitting them :)

> ChangeLog:8
> +	   Reviewed by Adrian Perez.

This should be “Reviewed by Adrian Perez de Castro“, because that is how
my name appears in “Tools/Scripts/webkitpy/common/config/contributors.json”

Even better: It is possible to leave the “Reviewed by OOPS” line without
typing the name of the reviewer, and then when a patch is marked as reviewed
(r+) in Bugzilla the “OOPS” will be replaced automatically when the patch gets
merged in the repository :)