[webkit-reviews] review granted: [Bug 220375] [GPU Process] Assertion under RenderLayerCompositor::computeCompositingRequirements() : [Attachment 422884] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Peng Liu
<peng.liu6 at apple.com>'s request for review:
Bug 220375: [GPU Process] Assertion under
RenderLayerCompositor::computeCompositingRequirements()
https://bugs.webkit.org/show_bug.cgi?id=220375

Attachment 422884: Patch

https://bugs.webkit.org/attachment.cgi?id=422884&action=review




--- Comment #18 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 422884
  --> https://bugs.webkit.org/attachment.cgi?id=422884
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422884&action=review

> Source/WebCore/html/HTMLMediaElement.h:149
> +    bool supportsAcceleratedRendering() const { return m_player &&
m_cachedSupportsAcceleratedRendering; }

Nit: if you cleared m_cachedSupportsAcceleratedRendering in
`clearMediaPlayer()`, this null-check won't be necessary.