[webkit-reviews] review granted: [Bug 223027] Improve font-variation-settings interpolation : [Attachment 422833] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 10 13:29:57 PST 2021


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at webkit.org>'s
request for review:
Bug 223027: Improve font-variation-settings interpolation
https://bugs.webkit.org/show_bug.cgi?id=223027

Attachment 422833: Patch

https://bugs.webkit.org/attachment.cgi?id=422833&action=review




--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 422833
  --> https://bugs.webkit.org/attachment.cgi?id=422833
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=422833&action=review

> Source/WebCore/animation/CSSPropertyAnimation.cpp:535
> +    ASSERT(from.size() == to.size());

Even though you check the sizes in canInterpolate, it might be better to keep
the return of the empty FontVariationSettings just in case.


More information about the webkit-reviews mailing list