[webkit-reviews] review granted: [Bug 215575] Do not shrink radio buttons bellow its size : [Attachment 422817] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 10 09:49:08 PST 2021
Darin Adler <darin at apple.com> has granted Sergio Villar Senin
<svillar at igalia.com>'s request for review:
Bug 215575: Do not shrink radio buttons bellow its size
https://bugs.webkit.org/show_bug.cgi?id=215575
Attachment 422817: Patch
https://bugs.webkit.org/attachment.cgi?id=422817&action=review
--- Comment #8 from Darin Adler <darin at apple.com> ---
Comment on attachment 422817
--> https://bugs.webkit.org/attachment.cgi?id=422817
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=422817&action=review
Code looks fine. Argument name not so good.
> Source/WebCore/platform/Theme.h:60
> + LengthSize minimumControlSize(ControlPart, const FontCascade&, const
LengthSize& zoomedSize, const LengthSize& nonShrinkableZoomedSize, float
zoomFactor) const;
Not sure the name is quite right here. I don’t really understand what a
"non-shrinkable size" is. Would it be larger, or smaller, than zoomed size? Is
this a "preferred size" or a "default size" or something?
More information about the webkit-reviews
mailing list